linux-kernel - Re: [PATCH 0/3] Small fixes for w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Feb 2012 18:06:08 +1100
From:	NeilBrown <neilb@...e.de>
To:	Thomas Weber <thomas.weber.linux@...glemail.com>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, GregKH <greg@...ah.com>,
	Thomas Weber <weber@...science.de>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org, Paul Walmsley <paul@...an.com>
Subject: Re: [PATCH 0/3] Small fixes for w1_bq27000 driver

On Sun, 19 Feb 2012 07:50:23 +0100 Thomas Weber
<thomas.weber.linux@...glemail.com> wrote:

> On 02/19/2012 03:10 AM, NeilBrown wrote:
> > The following three patches fix a problem with the w1 interface for
> > the bq27000 battery charge meter, and remove some unnecessary code.
> >
> > thanks,
> > NeilBrown
> >
> >
> > ---
> >
> > NeilBrown (3):
> >        w1_bq27000: Only one thread can access the bq27000 at a time.
> >        w1_bq27000 - remove w1_bq27000_write
> >        w1_bq27000: remove unnecessary NULL test.
> >
> >
> >   drivers/w1/slaves/w1_bq27000.c |   19 ++-----------------
> >   1 files changed, 2 insertions(+), 17 deletions(-)
> >
> Hello Neil,
> I have the following problem. The board not correctly reads the values 
> from the bq27000. It also doesn't detects if the bq27000 is connected. I 
> think it always reads 0xFF.
> 
> Do you have an omap3 board and a bq27000 battery?

Yes, I have an OMAP3 with the HDQ line connected to a battery with a bq27000
in it.  It now works fine.

When I first started working on it I would sometimes get problems with lots
of 0xFF being read, usually with lots of delays.

One problem was that during boot there would often be multiple threads
accessing the battery and tripping over each other.
The third patch of this set fixes that.

The other problem was power saving issues in the OMAP3 drivers.  These
we address with lots of help from Paul Walmsley.

You can find my current set of HDQ patches here:

http://neil.brown.name/git?p=gta04;a=shortlog;h=refs/heads/hdq

 (or git://neil.brown.name/gta04 hdq)

Most of these are from Paul.

Please let me know if they help.

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)