lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 19 Feb 2012 16:05:25 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Margarita Olaya Cabrera <magi@...mlogic.co.uk>,
	Liam Girdwood <lrg@...com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: tps65912: Initialize irq platform data properly

On Sun, Feb 19, 2012 at 3:50 PM, Axel Lin <axel.lin@...il.com> wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
>

The description only tells what you did, but why?

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/tps65912-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
> index 5fec23a..74fd8cb 100644
> --- a/drivers/mfd/tps65912-core.c
> +++ b/drivers/mfd/tps65912-core.c
> @@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
>                goto err;
>
>        init_data->irq = pmic_plat_data->irq;
> -       init_data->irq_base = pmic_plat_data->irq;
> +       init_data->irq_base = pmic_plat_data->irq_base;
>        ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
>        if (ret < 0)
>                goto err;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists