lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Feb 2012 08:07:38 +0100 From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> To: Hans-Christian Egtvedt <egtvedt@...fundet.no> Cc: Nicolas Ferre <nicolas.ferre@...el.com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kernel@...32linux.org Subject: Re: [PATCH 16/18] Atmel: move console default platform_device to serial driver On 10:17 Sat 18 Feb , Hans-Christian Egtvedt wrote: > Around Fri 17 Feb 2012 18:50:08 +0100 or thereabout, Nicolas Ferre wrote: > > From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> > > > > This variable spread on every SoC that is using the atmel_serial.c > > driver can be included directly into the latter. > > > > This will allow to compile multiple soc in the same kernel. > > Sounds like a good idea, but... > > <snipp AT91 changes> > > > diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c > > index 402a7bb..889c544 100644 > > --- a/arch/avr32/mach-at32ap/at32ap700x.c > > +++ b/arch/avr32/mach-at32ap/at32ap700x.c > > @@ -1055,8 +1055,6 @@ struct platform_device *__init at32_add_device_usart(unsigned int id) > > return at32_usarts[id]; > > } > > > > -struct platform_device *atmel_default_console_device; > > - > > void __init at32_setup_serial_console(unsigned int usart_id) > > { > > atmel_default_console_device = at32_usarts[usart_id]; > > I doubt this assignment will work if you remove the struct above. I did not > look at how AT91 does this, will it be similar affected? none the still exist in the kernel, its just moved Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists