linux-kernel - Re: Linux 3.3-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwqChUmmDfoYX7HRUUZg5s7nBOh834=g+7avj=yc42gGg@mail.gmail.com>
Date:	Sun, 19 Feb 2012 12:02:07 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	thomas@...3r.de, raven@...maw.net, linux-kernel@...r.kernel.org
Subject: Re: Linux 3.3-rc4

On Sun, Feb 19, 2012 at 11:49 AM, David Miller <davem@...emloft.net> wrote:
>
> A real shame, this should have used "__aligned_u64" from the
> beginning.

I agree. Sadly, this is exactly the kind of thing that is *really*
easy to overlook, and once it is overlooked we're screwed because
fixing it just breaks the native 32-bit case.

We probably should have made __u64 itself be marked as aligned, but
that's too late now too, unless somebody wants to go through and fix
any cases like this ;(

Binary compatibility is really important, and while arguably
compat-compatibility is slightly less critical, I think we should aim
to DTRT there too. I don't think we need to necessarily bend over
quite as far backwards for the compat case, but in places like this
where we are so close to being compatible - and not being compatible
kills the boot sequence and isn't just some theoretical thing - I do
think that it's worth

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/