linux-kernel - Re: [PATCH] atl1c: dont use highprio tx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120219.185956.2140542911171040902.davem@davemloft.net>
Date:	Sun, 19 Feb 2012 18:59:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	thomas@...3r.de, linux-kernel@...r.kernel.org, jcliburn@...il.com,
	chris.snook@...il.com, netdev@...r.kernel.org, jwboyer@...il.com
Subject: Re: [PATCH] atl1c: dont use highprio tx queue

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Feb 2012 07:43:11 +0100

> This driver attempts to use two TX rings but lacks proper support :
> 
> 1) IRQ handler only takes care of TX completion on first TX ring
> 2) the stop/start logic uses the legacy functions (for non multiqueue
> drivers)
> 
> This means all packets witk skb mark set to 1 are sent through high
> queue but are never cleaned and queue eventualy fills and block the
> device, triggering the infamous "NETDEV WATCHDOG" message. 
> 
> Lets use a single TX ring to fix the problem, this driver is not a real
> multiqueue one yet.
> 
> Minimal fix for stable kernels.
> 
> Reported-by: Thomas Meyer <thomas@...3r.de>
> Tested-by: Thomas Meyer <thomas@...3r.de>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/