linux-kernel - Re: [PATCH v5 3/5] Extcon: support multiple states at a device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Feb 2012 16:02:11 +0900
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, NeilBrown <neilb@...e.de>,
	Randy Dunlap <rdunlap@...otime.net>,
	Mike Lockwood <lockwood@...roid.com>,
	Arve Hjønnevag <arve@...roid.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Donggeun Kim <dg77.kim@...sung.com>, Greg KH <gregkh@...e.de>,
	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Morten CHRISTIANSEN <morten.christiansen@...ricsson.com>,
	John Stultz <john.stultz@...aro.org>,
	Joerg Roedel <joerg.roedel@....com>
Subject: Re: [PATCH v5 3/5] Extcon: support multiple states at a device.

On Mon, Feb 20, 2012 at 11:24 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Fri, Feb 10, 2012 at 03:40:36PM +0900, MyungJoo Ham wrote:
>
>> +     [EXTCON_AUDIO_IN]       = "Audio-in",
>> +     [EXTCON_AUDIO_OUT]      = "Audio-out",
>
> Can I suggest making these more specific - how about
>
>        [EXTCON_LINE_IN]        = "Line-in",
>        [EXTCON_LINE_OUT]       = "Line-out",
>        [EXTCON_MIC_IN]         = "Microphone",
>        [EXTCON_HEADPHONE_OUT]  = "Headphone",
>
> as a starting point?  The distinction between line and the other two is
> often pretty important from a UI/system interaction point of view.

Sure, this looks more generic. I'll add them along with SPDIF in/out.

>
>> +     /* TODO: remove before submit */
>> +     pr_info("[%s][%d]\n", buffer, enabled);
>
> :)

Whoops...

-- 
MyungJoo Ham, Ph.D.
System S/W Lab, Software Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/