linux-kernel - Re: [PATCH] amba-pl011/dma: Add check for the residue in DMA callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Feb 2012 09:31:21 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Chanho Min <chanho0207@...il.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Per Forlin <per.friden@...ricsson.com>,
	Alan Cox <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Rabin VINCENT <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH] amba-pl011/dma: Add check for the residue in DMA callback

On Mon, Feb 20, 2012 at 2:24 AM, Chanho Min <chanho0207@...il.com> wrote:

> In DMA-operated uart, I found that rx data can be taken by the UART
> interrupts during the DMA irq handler. pl011_int is occurred just
> before it goes inside spin_lock_irq. When it returns to the callback,
> DMA buffer already has been flushed. Then, pl011_dma_rx_chars gets
> invalid data. So I add check for the residue as the patch bellow.
>
> Signed-off-by: Chanho Min <chanho.min@....com>

Looks correct!
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/