linux-kernel - Re: [RFC PATCH 14/14] sched: implement usage tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329754301.2293.358.camel@twins>
Date:	Mon, 20 Feb 2012 17:11:41 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Paul Turner <pjt@...gle.com>
Cc:	linux-kernel@...r.kernel.org, Venki Pallipadi <venki@...gle.com>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Mike Galbraith <efault@....de>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
	Ben Segall <bsegall@...gle.com>, Ingo Molnar <mingo@...e.hu>,
	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
Subject: Re: [RFC PATCH 14/14] sched: implement usage tracking

On Fri, 2012-02-17 at 02:54 -0800, Paul Turner wrote:
> On Thu, Feb 16, 2012 at 5:37 AM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> > On Wed, 2012-02-01 at 17:38 -0800, Paul Turner wrote:
> >>  static inline void update_rq_runnable_avg(struct rq *rq, int runnable)
> >>  {
> >> -       __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable);
> >> +       __update_entity_runnable_avg(rq->clock_task, &rq->avg, runnable,
> >> +                                    runnable);
> >
> > Its not immediately obvious why we use @runnable for @running,
> 
> Isn't it?  An rq is the root of all scheduling -- if there are any
> runnable tasks than one of them better be running when this is called.
> 
> I can add a comment to this effect.

Ah, indeed. Yes a comment would be good ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/