linux-kernel - Re: [PATCH] trace: don't print an extra separator of flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329761354.25686.32.camel@gandalf.stny.rr.com>
Date:	Mon, 20 Feb 2012 13:09:14 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andrew Vagin <avagin@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] trace: don't print an extra separator of flags

On Sun, 2012-02-19 at 14:16 +0300, Andrew Vagin wrote:
> From: Andrey Vagin <avagin@...nvz.org>
> 
> It occurs if __print_flags is used more than once

Hi, which tracepoint does this? I like to see what the issue is.

Thanks,

-- Steve

> 
> Signed-off-by: Andrew Vagin <avagin@...nvz.org>
> ---
>  kernel/trace/trace_output.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> index 0d6ff35..3efd718 100644
> --- a/kernel/trace/trace_output.c
> +++ b/kernel/trace/trace_output.c
> @@ -300,7 +300,7 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
>  	unsigned long mask;
>  	const char *str;
>  	const char *ret = p->buffer + p->len;
> -	int i;
> +	int i, first = 1;
>  
>  	for (i = 0;  flag_array[i].name && flags; i++) {
>  
> @@ -310,8 +310,10 @@ ftrace_print_flags_seq(struct trace_seq *p, const char *delim,
>  
>  		str = flag_array[i].name;
>  		flags &= ~mask;
> -		if (p->len && delim)
> +		if (!first && delim)
>  			trace_seq_puts(p, delim);
> +		else
> +			first = 0;
>  		trace_seq_puts(p, str);
>  	}
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/