linux-kernel - Re: [PATCH] thp: allow a hwpoisoned head page to be put back to LRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120220212955.GD10222@redhat.com>
Date:	Mon, 20 Feb 2012 22:29:55 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Dean Nelson <dnelson@...hat.com>
Cc:	linux-mm@...ck.org, Jin Dongming <jin.dongming@...css.fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thp: allow a hwpoisoned head page to be put back to LRU

On Mon, Feb 20, 2012 at 04:10:40PM -0500, Dean Nelson wrote:
> Andrea Arcangeli pointed out to me that a check in __memory_failure() which
> was intended to prevent THP tail pages from being checked for the absence
> of the PG_lru flag (something that is always the case), was also preventing
> THP head pages from being checked.
> 
> A THP head page could actually benefit from the call to shake_page() by
> ending up being put back to a LRU, provided it had been waiting in a
> pagevec array.
> 
> Andrea suggested that the "!PageTransCompound(p)" in the if-statement
> should be replaced by a "!PageTransTail(p)", thus allowing THP head pages
> to be checked and possibly shaken.
> 
> Signed-off-by: Dean Nelson <dnelson@...hat.com>

Reviewed-by: Andrea Arcangeli <aarcange@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/