[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120220223313.GD32708@quack.suse.cz>
Date: Mon, 20 Feb 2012 23:33:13 +0100
From: Jan Kara <jack@...e.cz>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Jan Kara <jack@...e.cz>, LKML <linux-kernel@...r.kernel.org>,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
Andrew Morton <akpm@...ux-foundation.org>,
Eric Sandeen <sandeen@...hat.com>,
Dave Chinner <david@...morbit.com>,
Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH 01/11] perf: Push file_update_time() into
perf_mmap_fault()
On Thu 16-02-12 14:50:47, Peter Zijlstra wrote:
> On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote:
> > CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > CC: Ingo Molnar <mingo@...e.hu>
> > CC: Paul Mackerras <paulus@...ba.org>
> > CC: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> > Signed-off-by: Jan Kara <jack@...e.cz>
> > ---
> > kernel/events/core.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index ba36013..61a67f3 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -3316,8 +3316,10 @@ static int perf_mmap_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
> > int ret = VM_FAULT_SIGBUS;
> >
> > if (vmf->flags & FAULT_FLAG_MKWRITE) {
> > - if (vmf->pgoff == 0)
> > + if (vmf->pgoff == 0) {
> > ret = 0;
> > + file_update_time(vma->vm_file);
> > + }
> > return ret;
> > }
>
> Its an anon filedesc, there's no actual file and while I guess one could
> probably call fstat() on it, people really shouldn't care.
>
> So feel free to introduce this patch to the bitbucket.
Thanks for letting me know. Patch removed.
Honza
--
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists