linux-kernel - Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120219.190504.1559694496609520740.davem@davemloft.net>
Date:	Sun, 19 Feb 2012 19:05:04 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	danny.kukawka@...ect.de
Cc:	vapier@...too.org, sonic.zhang@...log.com,
	jeffrey.t.kirsher@...el.com, bob.liu@...log.com,
	uclinux-dist-devel@...ckfin.uclinux.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes
 in arch/blackfin

From: Danny Kukawka <danny.kukawka@...ect.de>
Date: Fri, 17 Feb 2012 11:57:54 +0100

> On Freitag, 17. Februar 2012, Mike Frysinger wrote:
>> On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
>> > +                       netdev_warn(ndev, "Setting Ethernet MAC to a
>> > random one\n"); +                       eth_hw_addr_random(ndev);
>>
>> would it make sense to have the core dump the warning ?
> 
> Maybe. Many drivers already print information about setting a random mac 
> address to a netdevice. Some with printk, some via 
> netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum 
> methods. I could unify this, in a next step with a netdev_info in 
> eth_hw_addr_random(), if it's okay for David. 

All of these log messages are stupid and should be removed.

If someone is seriously interested in it, we have the damn random
address boolean state which can be inspected in the sysfs addr_assign_type
node for the device.

End of story.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/