linux-kernel - Re: [PATCH 04/18] ARM: at91: make ST (System Timer) soc independent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F41A76D.1070409@gmail.com>
Date:	Mon, 20 Feb 2012 12:52:45 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/18] ARM: at91: make ST (System Timer) soc independent

On 20/02/12 12:38, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 11:22 Mon 20 Feb     , Ryan Mallon wrote:
>> On 18/02/12 04:49, Nicolas Ferre wrote:
>>
>>> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
>>>
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
>>> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
>>> ---
>>>  arch/arm/mach-at91/at91rm9200.c              |    4 +-
>>>  arch/arm/mach-at91/at91rm9200_time.c         |   37 ++++++++++++++++----------
>>>  arch/arm/mach-at91/generic.h                 |    1 +
>>>  arch/arm/mach-at91/include/mach/at91_st.h    |   32 +++++++++++++++-------
>>>  arch/arm/mach-at91/include/mach/at91rm9200.h |    2 +-
>>>  drivers/watchdog/at91rm9200_wdt.c            |    8 +++---
>>>  6 files changed, 53 insertions(+), 31 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
>>
>> Hi Jean, Nicolas,
>>
>> Patch looks mostly good, couple of points below.
>>
>> ~Ryan
>>
>> <snip>
>>
>>>  	/* Cancel any pending alarm; flush any pending IRQ */
>>> -	at91_sys_write(AT91_ST_RTAR, alm);
>>> -	(void) at91_sys_read(AT91_ST_SR);
>>> +	at91_st_write(AT91_ST_RTAR, alm);
>>> +	(void) at91_st_read(AT91_ST_SR);
>>
>>
>> Can we please remove the (void) casting of the return value when making
>> this change, especially since at91_st_read is now a macro which doesn't
>> even have a return value. Same in a few other places.
> modification done by script and it's no the scope of this patch


That isn't an excuse to leave incorrect code there. It is a simple fix.

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/