linux-kernel - Re: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120221140103.773d0962@stein>
Date:	Tue, 21 Feb 2012 14:01:03 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	santosh nayak <santoshprasadnayak@...il.com>
Cc:	linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] Driver: firewire: Use the macro DMA_BIT_MASK().

On Feb 21 santosh nayak wrote:
> Use the macro DMA_BIT_MASK instead of the constant  0xffffffff
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com>
> ---
>  drivers/firewire/nosy.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
> index 763626b..a7c4422 100644
> --- a/drivers/firewire/nosy.c
> +++ b/drivers/firewire/nosy.c
> @@ -36,7 +36,7 @@
>  #include <linux/timex.h>
>  #include <linux/uaccess.h>
>  #include <linux/wait.h>
> -
> +#include <linux/dma-mapping.h>
>  #include <linux/atomic.h>
>  #include <asm/byteorder.h>
>  
> @@ -536,7 +536,7 @@ add_card(struct pci_dev *dev, const struct pci_device_id *unused)
>  	u32 p, end;
>  	int ret, i;
>  
> -	if (pci_set_dma_mask(dev, 0xffffffff)) {
> +	if (pci_set_dma_mask(dev, DMA_BIT_MASK(32))) {
>  		dev_err(&dev->dev,
>  		    "DMA address limits not supported for PCILynx hardware\n");
>  		return -ENXIO;

Thanks, I will commit it to linux1394.git soon.
-- 
Stefan Richter
-=====-===-- --=- =-=-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/