linux-kernel - re : PROBLEM: Data corruption when pasting large data to terminal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4F439E17.8090507@parrot.com>
Date:	Tue, 21 Feb 2012 14:37:27 +0100
From:	Matthieu CASTET <matthieu.castet@...rot.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Egmont Koblinger <egmont@...il.com>, Alan Cox <alan@...hat.com>
Subject: re : PROBLEM: Data corruption when pasting large data to terminal

Hi,

> - I couldn't reproduce with cat-like applications, I have a feeling
> perhaps the bug only occurs in raw terminal mode, but I'm really not
> sure about this.

We saw in our case a possible data corruption in the tty layer :
in n_tty the n_tty_receive_buf can drop characters if it can't copy all of them
in the tty circular buffer.

A fix should be to remove tty->receive_room and make n_tty_receive_buf  return
the number of bytes copied.

A patch to correct this was done in b1c43f82c5aa265442f82dba31ce985ebb7aa71c,
but it was reverted because it was buggy.

May be you should check that this is not your problem.

Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/