linux-kernel - Re: [RFC] block: fix __blkdev_get and add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120221011552.GB15898@dhcp-172-17-108-109.mtv.corp.google.com>
Date:	Mon, 20 Feb 2012 17:15:52 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	Jun'ichi Nomura <j-nomura@...jp.nec.com>
Subject: Re: [RFC] block: fix __blkdev_get and add_disk race condition

Hello,

Nice catch.

On Sat, Feb 18, 2012 at 06:26:13PM +0100, Stanislaw Gruszka wrote:
> As drawback, I do not teardown on sysfs file create error, because I do
> not know how to nullify disk->ev (since it can be used).

add_disk() error handling is mostly non-existent and the error
behavior should be acceptable (no sysfs files created but everything
else behaves the same).

> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/