linux-kernel - Re: [PATCH] CHROMIUM: Input: synaptics - filter out the events with low z values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS+omAK-dWjJjjDDXtwM90bTx--ngEL6KTtxzdcQGtd-xEPEQ@mail.gmail.com>
Date:	Wed, 22 Feb 2012 00:35:09 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Chung-yih Wang <cywang@...omium.org>
Cc:	Alessandro Rubini <rubini@...vis.unipv.it>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CHROMIUM: Input: synaptics - filter out the events with
 low z values

On Tue, Feb 21, 2012 at 11:07 PM, Chung-yih Wang <cywang@...omium.org> wrote:
> The single touch path imposes a minimum z value (with hysterisis) before
> registering BTN_TOUCH. Apply the same (hard coded) threshold when
> deciding how many fingers to report in the semi-mt path.
>
> This patch improves performance of the Google Cr-48 chromebook's
> extremely sensitive Synaptics profile sensor touchpad by filtering out
> touch events for hovering fingers.
>
> Note: We continue to use the same hard coded threshold value used in the
> single touch case as it appears this works just as well on these
> multitouch profile sensor pads as on whatever pads it was originally
> discovered.
>
> Signed-off-by: Chung-Yih Wang <cywang@...omium.org>

Reviewed-by: Daniel Kurtz <djkurtz@...omium.org>

> ---
>  drivers/input/mouse/synaptics.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 8081a0a..7936a1a 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -568,17 +568,22 @@ static void synaptics_report_semi_mt_slot(struct input_dev *dev, int slot,
>        }
>  }
>
> +static bool finger_touched(const struct synaptics_hw_state *hw)
> +{
> +       return (hw->z > 30);
> +}
> +
>  static void synaptics_report_semi_mt_data(struct input_dev *dev,
>                                          const struct synaptics_hw_state *a,
>                                          const struct synaptics_hw_state *b,
>                                          int num_fingers)
>  {
> -       if (num_fingers >= 2) {
> +       if ((num_fingers >= 2) && finger_touched(a) && finger_touched(b)) {
>                synaptics_report_semi_mt_slot(dev, 0, true, min(a->x, b->x),
>                                              min(a->y, b->y));
>                synaptics_report_semi_mt_slot(dev, 1, true, max(a->x, b->x),
>                                              max(a->y, b->y));
> -       } else if (num_fingers == 1) {
> +       } else if ((num_fingers == 1) && finger_touched(a)) {
>                synaptics_report_semi_mt_slot(dev, 0, true, a->x, a->y);
>                synaptics_report_semi_mt_slot(dev, 1, false, 0, 0);
>        } else {
> @@ -1040,7 +1045,8 @@ static void synaptics_process_packet(struct psmouse *psmouse)
>         * BTN_TOUCH has to be first as mousedev relies on it when doing
>         * absolute -> relative conversion
>         */
> -       if (hw.z > 30) input_report_key(dev, BTN_TOUCH, 1);
> +       if (finger_touched(&hw))
> +               input_report_key(dev, BTN_TOUCH, 1);
>        if (hw.z < 25) input_report_key(dev, BTN_TOUCH, 0);
>
>        if (num_fingers > 0) {
> --
> 1.7.7.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/