linux-kernel - Re: [PATCH v3 2/2] mmc: card: Adding support for Sanitize in eMMC v4.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F43DCBA.5070605@codeaurora.org>
Date:	Tue, 21 Feb 2012 10:04:42 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Yaniv Gardi <ygardi@...eaurora.org>
CC:	linux-mmc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	axboe@...nel.dk, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] mmc: card: Adding support for Sanitize in eMMC
 v4.5

On 02/21/12 06:00, Yaniv Gardi wrote:
> @@ -922,6 +918,44 @@ out:
>  	return err ? 0 : 1;
>  }
>  
> +int mmc_blk_issue_sanitize_rq(struct mmc_queue *mq,
> +			       struct request *req)
> +{
> +	struct mmc_blk_data *md = mq->data;
> +	struct mmc_card *card = md->queue.card;
> +	int err = 0;
> +
> +	if (!(mmc_can_sanitize(card) && (mq->card->host->caps2 & MMC_CAP2_SANITIZE))) {
> +		pr_err("%s: SANITIZE is not supported", __func__);
> +		err = -EOPNOTSUPP;
> +		goto out;
> +	}
> +
> +	pr_info("%s: SANITIZE is supported", __func__);

These look like debug printks. Please remove them.

> +
> +	mmc_sd_card_set_sanitize_in_progress(card);
> +
> +	pr_info("%s: issueing SANITIZE command...", __func__);
> +
> +	err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> +					 EXT_CSD_SANITIZE_START, 1, 0);
> +
> +	pr_info("%s: SANITIZE command returned...", __func__);
> +
> +	if (err)
> +		pr_err("%s: mmcblk: mmc_switch() failed. err=%d\n",
> +		       __func__, err);
> +
> +	mmc_sd_card_set_sanitize_completed(card);
> +
> +out:
> +	spin_lock_irq(&md->lock);
> +	__blk_end_request(req, err, blk_rq_bytes(req));
> +	spin_unlock_irq(&md->lock);
> +
> +	return err ? 0 : 1;
> +}
> +
>  static int mmc_blk_issue_flush(struct mmc_queue *mq, struct request *req)
>  {
>  	struct mmc_blk_data *md = mq->data;
> @@ -181,6 +186,11 @@ int mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card,
>  	if (mmc_can_erase(card))
>  		mmc_queue_setup_discard(mq->queue, card);
>  
> +	if ((mmc_can_sanitize(card) && (host->caps2 & MMC_CAP2_SANITIZE)))
> +		mmc_queue_setup_sanitize(mq->queue);
> +	else
> +		pr_info("%s - card doesn't support sanitize", __func__);

debug printk again?

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/