linux-kernel - Re: Linux 3.3-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzNdESjFuN9PS8RcwfmLQK3DrB8Cfzx5jJk0ZjJCy8xcg@mail.gmail.com>
Date:	Tue, 21 Feb 2012 14:07:32 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Ian Kent <raven@...maw.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 3.3-rc4

On Tue, Feb 21, 2012 at 10:58 AM, Thomas Meyer <thomas@...3r.de> wrote:
> Am Sonntag, den 19.02.2012, 10:45 -0800 schrieb Linus Torvalds:
>>
>> Does this fix it?
>
> yes, it does!

Do  you know if anybody ever applied that disgusting (and incorrect -
the 4-byte off thing *only* happens in 32-bit mode with an x86-64
kernel - so the other architecture strcmp's are wrong, and even the
x86-64 strcmp is valid only when compiling as a legacy 32-bit x86 app)
patch of yours?

Because if that actually did happen, there are i386 binaries that are
now broken and know of the kernel bug as Ian was afraid there would
be.

But hopefully that patch never got anywhere, and we could still fix
this in the kernel with my suggested patch.

Not to say that *my* patch isn't also disgusting, of course. But at
least my patch fixes a real compat task problem.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/