linux-kernel - Re: [PATCH v2 3/3] i387: support lazy restore of FPU state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329862775.29790.268.camel@sbsiddha-desk.sc.intel.com>
Date:	Tue, 21 Feb 2012 14:19:35 -0800
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] i387: support lazy restore of FPU state

On Tue, 2012-02-21 at 13:57 -0800, Linus Torvalds wrote:
> On Tue, Feb 21, 2012 at 1:54 PM, Suresh Siddha
> <suresh.b.siddha@...el.com> wrote:
> >
> > Reviewing this code, I think we need to set the 'last_cpu' to an invalid
> > number in the fpu_alloc too. Appended is the patch.
> 
> I cleared fpu_counter in copy_thread() instead.

Hmm, didn't pay attention to that patch. Too many patches ;(

> Doing this in fpu_alloc() isn't necessarily a bad idea, though.

yes, I think we should do this in fpu_alloc() or bit more explicitly by
updating 'last_cpu' in copy_thread().

Someone experimenting with removing fpu pre-load may not realize this
subtle issue.

thanks,
suresh




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/