linux-kernel - Re: [PATCH 4/10] mm/memcg: apply add/del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1202211421170.2012@eggly.anvils>
Date:	Tue, 21 Feb 2012 14:25:54 -0800 (PST)
From:	Hugh Dickins <hughd@...gle.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
cc:	Hugh Dickins <hughd@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Ying Han <yinghan@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/10] mm/memcg: apply add/del_page to lruvec

Many thanks for inspecting these, and so soon.

On Tue, 21 Feb 2012, KAMEZAWA Hiroyuki wrote:
> 
> Hmm.. a nitpick.
> 
> You do 
>   lruvec = mem_cgroup_page_lruvec(page, zone);
> 
> What is the difference from
> 
>   lruvec = mem_cgroup_page_lruvec(page, page_zone(page)) 
> 
> ?

I hope they were equivalent: I just did it that way because in all cases
the zone had already been computed, so that saved recomputing it - as I
understand it, in some layouts (such as mine) it's pretty cheap to work
out the page's zone, but in others an expense to be avoided.

But then you discovered that it soon got removed again anyway.

Hugh

> 
> If we have a function
>   lruvec = mem_cgroup_page_lruvec(page)
> 
> Do we need 
>   lruvec = mem_cgroup_page_lruvec_zone(page, zone) 
> 
> ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/