linux-kernel - Re: compat: autofs v5 packet size ambiguity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyh1NmBt0LwR3+iD6B-Xa8wAs-nGJ0MBouPhTzWUi8W5g@mail.gmail.com>
Date:	Tue, 21 Feb 2012 20:56:36 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>, Ian Kent <raven@...maw.net>
Cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	autofs@...r.kernel.org, Thomas Meyer <thomas@...3r.de>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: compat: autofs v5 packet size ambiguity - update

On Tue, Feb 21, 2012 at 7:47 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> And then it does a AUTOFS_IOC_PROTOVER ioctl to see what the protocol
> version is.
>
> So we could just decide that
>
>  (a) we add a mount option for the packet size (or just "v6" - which
> would be "v5 with a fixed packet size")
>
>  (b) in the absence of an explicit mount option, we look at
> is_compat_task() for the first AUTOFS_IOC_PROTOVER ioctl we get.

Ok, so here's a patch that does that. Well, it doesn't do that (a)
part, but it does the auto-detection of whether the daemon is a compat
process or not.

THIS IS UNTESTED. Thomas - could you test this in your environment? I
added your "Tested-by:", but that's really for the previous patch that
tested is_compat_task() in the wrong context.

                        Linus

View attachment "0001-autofs-work-around-unhappy-compat-problem-on-x86-64.patch" of type "text/x-patch" (5102 bytes)