linux-kernel - Re: [PATCH v2 07/19] ARM: at91/pm_slowclock: function slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120222095250.GV22562@n2100.arm.linux.org.uk>
Date:	Wed, 22 Feb 2012 09:52:50 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	plagnioj@...osoft.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, rmallon@...il.com
Subject: Re: [PATCH v2 07/19] ARM: at91/pm_slowclock: function slow_clock()
	accepts parameters

On Wed, Feb 22, 2012 at 10:39:33AM +0100, Nicolas Ferre wrote:
> @@ -232,7 +246,7 @@ static int at91_pm_enter(suspend_state_t state)
>  				/* copy slow_clock handler to SRAM, and call it */
>  				memcpy(slow_clock, at91_slow_clock, at91_slow_clock_sz);
>  #endif
> -				slow_clock();
> +				slow_clock(at91_pmc_base, at91_ramc0_base, at91_ramc1_base);

This should be updated to use the fncpy() stuff if there's any chance that
you'll be supporting Thumb-2.  Using fncpy() is probably a good idea even
if you aren't.  See asm/fncpy.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/