linux-kernel - Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1986.1329905936@redhat.com>
Date:	Wed, 22 Feb 2012 10:18:56 +0000
From:	David Howells <dhowells@...hat.com>
To:	Bobby Powers <bobbypowers@...il.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org, hpa@...or.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH tip/x86/x32] fs: fix close_on_exec pointer in alloc_fdtable

Bobby Powers <bobbypowers@...il.com> wrote:

> alloc_fdtable allocates space for the open_fds and close_on_exec
> bitfields together, as 2 * nr / BITS_PER_BYTE.  close_on_exec needs to
> point to open_fds + nr / BITS_PER_BYTE, not open_fds + nr /
> BITS_PER_LONG, as introducted in 1fd36adc: Replace the fd_sets in
> struct fdtable with an array of unsigned longs.
> 
> Signed-off-by: Bobby Powers <bobbypowers@...il.com>

Yes, you're right.  At one point I changed data to be an unsigned long *.

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/