linux-kernel - Re: [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings in Version.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120222112144.GC2491@localhost>
Date:	Wed, 22 Feb 2012 11:21:44 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Pradheep Shrinivasan <pradheep.sh@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, lucas.demarchi@...fusion.mobi,
	devel@...verdev.osuosl.org, devel@...uxdriverproject.org,
	joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warnings
 in Version.h

On Tue, Feb 21, 2012 at 01:10:06AM +0530, Pradheep Shrinivasan wrote:

> > Are you asking me if I'm going to NAK your patch?  No.  It's an
> > unfortunate thing.  Checkpatch.pl is going around telling people to
> > add bogus parenthesis everywhere, and no one likes to redo their
> > patches.  And I feel like a jerk for telling people that they should
> > redo their patches.  And checkpatch.pl is a robot which has more
> > energy than I do.

In theory the number of things it gets right outweigh the things it gets
wrong and you do save energy overall.

I will poke checkpatch to try and stop it getting these wrong.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/