linux-kernel - Re: [PATCH] mfd: wm8994: Return error when device ID mismatch is detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120222134520.GL7340@opensource.wolfsonmicro.com>
Date:	Wed, 22 Feb 2012 13:45:20 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Ian Lartey <ian@...nsource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: wm8994: Return error when device ID mismatch is
 detected

On Wed, Feb 22, 2012 at 10:24:44AM +0800, Axel Lin wrote:
> We base on wm8994->type to set wm8994->supplies and wm8994->num_supplies.
> But in current code, wm8994->type may be changed when device ID mismatch is
> detected. If we change wm8994->type, then the wm8994->supplies and
> wm8994->num_supplies settings are wrong.
> 
> Fix it by return error immediately when device ID mismatch is detected.

No, there are valid use cases for registering as the wrong device.  It's
not ideal to have the wrong supply set but it's going to cause more harm
than good to fail hard on this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)