linux-kernel - Re: [PATCH] regmap: Append device name in the root debugfs dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120222135709.GA14766@opensource.wolfsonmicro.com>
Date:	Wed, 22 Feb 2012 13:57:09 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Append device name in the root debugfs dir

On Wed, Feb 22, 2012 at 01:53:03PM +0000, Dimitris Papastamos wrote:

>  void regmap_debugfs_init(struct regmap *map)
>  {
> -	map->debugfs = debugfs_create_dir(dev_name(map->dev),
> -					  regmap_debugfs_root);
> +	char name[64];

That's a magic number, where did it come from?

> +
> +	snprintf(name, sizeof(name), "%s-%s",
> +		 dev_name(map->dev), map->dev->driver->name);
> +
> +	map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);

No, keep the directory name the same and add a new file.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)