linux-kernel - Re: [PATCH v2 05/19] ARM: at91/ST: remove not needed casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Feb 2012 09:24:30 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	plagnioj@...osoft.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux@....linux.org.uk
Subject: Re: [PATCH v2 05/19] ARM: at91/ST: remove not needed casts

On 22/02/12 20:39, Nicolas Ferre wrote:

> Remove the unnecessary (void) cast on at91_st_read()
> return value.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>


Thanks Nicolas.

Acked-by: Ryan Mallon <rmallon@...il.com>

> ---
>  arch/arm/mach-at91/at91rm9200_time.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91rm9200_time.c b/arch/arm/mach-at91/at91rm9200_time.c
> index 0c1980c..dd7f782 100644
> --- a/arch/arm/mach-at91/at91rm9200_time.c
> +++ b/arch/arm/mach-at91/at91rm9200_time.c
> @@ -111,7 +111,7 @@ clkevt32k_mode(enum clock_event_mode mode, struct clock_event_device *dev)
>  {
>  	/* Disable and flush pending timer interrupts */
>  	at91_st_write(AT91_ST_IDR, AT91_ST_PITS | AT91_ST_ALMS);
> -	(void) at91_st_read(AT91_ST_SR);
> +	at91_st_read(AT91_ST_SR);
>  
>  	last_crtr = read_CRTR();
>  	switch (mode) {
> @@ -157,7 +157,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
>  
>  	/* Cancel any pending alarm; flush any pending IRQ */
>  	at91_st_write(AT91_ST_RTAR, alm);
> -	(void) at91_st_read(AT91_ST_SR);
> +	at91_st_read(AT91_ST_SR);
>  
>  	/* Schedule alarm by writing RTAR. */
>  	alm += delta;
> @@ -192,7 +192,7 @@ void __init at91rm9200_timer_init(void)
>  	/* Disable all timer interrupts, and clear any pending ones */
>  	at91_st_write(AT91_ST_IDR,
>  		AT91_ST_PITS | AT91_ST_WDOVF | AT91_ST_RTTINC | AT91_ST_ALMS);
> -	(void) at91_st_read(AT91_ST_SR);
> +	at91_st_read(AT91_ST_SR);
>  
>  	/* Make IRQs happen for the system timer */
>  	setup_irq(AT91_ID_SYS, &at91rm9200_timer_irq);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/