linux-kernel - Re: [PATCH] drivers/scsi/pm8001/pm8001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA9_cmc6w_Tn+GbSubCcGxvE2w6yyDyWP_WgY3H5d6iasyqvRQ@mail.gmail.com>
Date:	Wed, 22 Feb 2012 14:55:31 -0800
From:	Dan Williams <dan.j.williams@...el.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	jack_wang@...sh.com, kernel-janitors@...r.kernel.org,
	lindar_liu@...sh.com,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/scsi/pm8001/pm8001_sas.c: move timer start

On Wed, Feb 22, 2012 at 12:55 PM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
>
> Move the add_timer below some instructions that do not seem to require a
> timer and that in one case can fail, thus avoiding the need for a
> corresponding del_timer.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
> I don't fully understand the code, and have not tested the change.  Think
> of this patch as more of a question as to whether this is the right thing
> to do.

This patch makes sense to me... don't start the timer until we're sure
that the task is going to be submitted, or at least remember to
del_timer() before returning.

Looks like pm8001_exec_internal_tmf_task() gets this right.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/