linux-kernel - Re: [PATCH] x86, efi: Fix unaligned access and endian issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120223105444.f0585f65e18be0360f9bfdb9@canb.auug.org.au>
Date:	Thu, 23 Feb 2012 10:54:44 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86, efi: Fix unaligned access and endian issues

Hi Matt,

On Wed, 22 Feb 2012 22:58:28 +0000 Matt Fleming <matt@...sole-pimps.org> wrote:
>
> Thanks Stephen, this bzImage works fine on my setup.

Great.

> > One little thing is that those two new functions may we warned about as
> > unused if CONFIG_EFI_STUB is not set (I have not done that build yet).
> 
> Should be OK because they're static inline (it at least doesn't warn
> here).

And I did the build and they don;t warn here either, so good.

> Peter was talking about exporting unaligned.h for host tools so this
> patch will probably go through another iteration anyway.

OK.  In that case, I will add this version to my fixes tree in linux-next
just so that the allmodconfig builds work again.  I will remove it when
it turns up (presumably in the tip tree).

Just to be clear, it wasn't the unaligned accesses that were causing me a
problem (PowerPC copes), it was the endian issues.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped