linux-kernel - Re: + locks-new-proc-lockinfo.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACVxJT9GDB-BXW-B57=_c8s3EtZ=22BEKi8a_0tdr+YDkviYVg@mail.gmail.com>
Date:	Thu, 23 Feb 2012 13:54:48 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	dave@....org, bfields@...ldses.org, ebiederm@...ssion.com,
	matthew@....cx, viro@...iv.linux.org.uk
Subject: Re: + locks-new-proc-lockinfo.patch added to -mm tree

On Wed, Feb 22, 2012 at 12:06 AM,  <akpm@...ux-foundation.org> wrote:
> +static void lockinfo_get_status(struct seq_file *f, struct file_lock *fl,

All caps sucks.

> +       if (fl->fl_type & LOCK_MAND) {
> +               seq_printf(f, "Access:\t\t %s\n",
> +                          (fl->fl_type & LOCK_READ)
> +                          ? (fl->fl_type & LOCK_WRITE) ? "RW   " : "READ "
> +                          : (fl->fl_type & LOCK_WRITE) ? "WRITE" : "NONE ");

I think using one of --, r-, -w, rw is nicer.
Trailing whitespace, why?

> +       } else {
> +               seq_printf(f, "Access:\t\t %s\n",
> +                          (lease_breaking(fl))
> +                          ? (fl->fl_type & F_UNLCK) ? "UNLCK" : "READ "
> +                          : (fl->fl_type & F_WRLCK) ? "WRITE" : "READ ");

Trailing whitespace.

> +       if (IS_POSIX(fl)) {
> +               if (fl->fl_end == OFFSET_MAX)
> +                       seq_printf(f, "Start-end:\t %Ld-EOF\n\n", fl->fl_start);
> +               else
> +                       seq_printf(f, "Start-end:\t %Ld-%Ld\n\n", fl->fl_start, fl->fl_end);
> +       } else {
> +               seq_printf(f, "Start-end:\t 0-EOF\n\n");

Separate start/end or range, if you want to keep it on one line.