linux-kernel - Re: [PATCH 5/5] genirq: Mark IRQ thread handlers with irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120223131942.GC1978@dhcp-26-207.brq.redhat.com>
Date:	Thu, 23 Feb 2012 14:19:43 +0100
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Oleg Nesterov <onestero@...hat.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] genirq: Mark IRQ thread handlers with irq_thread flag

Олег,

Ты совершенно прав. Эта проверка -- кривая. Мне лучше отправить self-nack на
этот конкретный патч или заслать всю серию без этого патча заново?

> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -896,7 +896,7 @@ void do_exit(long code)
>  
>  	WARN_ON(blk_needs_flush_plug(tsk));
>  
> -	if (unlikely(in_interrupt()))
> +	if (unlikely(!tsk->irq_thread && in_interrupt()))
>  		panic("Aiee, killing interrupt handler!");
>  	if (unlikely(!tsk->pid))
>  		panic("Attempted to kill the idle task!");
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index a94466d..d02d4f6 100644

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/