lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Feb 2012 09:26:13 -0500 From: Matt Porter <mporter@...com> To: "Hiremath, Vaibhav" <hvaibhav@...com> Cc: Tony Lindgren <tony@...mide.com>, Russell King <linux@....linux.org.uk>, Linux OMAP List <linux-omap@...r.kernel.org>, Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators On Thu, Feb 23, 2012 at 12:08:34PM +0000, Hiremath, Vaibhav wrote: > On Wed, Feb 22, 2012 at 22:15:03, Porter, Matt wrote: > > /* > > * Initialize smsc911x device connected to the GPMC. Note that we > > * assume that pin multiplexing is done in the board-*.c file, > > @@ -51,10 +97,16 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *board_data) > > { > > struct platform_device *pdev; > > unsigned long cs_mem_base; > > - int ret; > > + int ret, err; > > > > Do you really need another variable here? Can't you use "ret" here? No we don't, thanks for catching this. I posted a v3 that addresses it. Tony: can you revert v2 for v3 that I just posted which addresses Vaibhav's comment? -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists