lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Feb 2012 11:57:47 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ram Pai <linuxram@...ibm.com>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] PCI: Make pci bridge reallocating enabled/disabled

On Fri, 10 Feb 2012 15:33:50 -0800
Yinghai Lu <yinghai@...nel.org> wrote:
> +enum enable_type {
> +	enable_not_set = -1,
> +	enable_no_user,
> +	enable_no_detected,
> +	enable_yes_user,
> +	enable_yes_detected,
> +};

How about:
  user_enabled
  user_disabled
  auto_enabled
  auto_disabled
?

enable_no_* seems a bit confusing...

also the help text in kernel-parameters.txt should mention the config
option and describe default behavior with and without that config
option enabled.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists