linux-kernel - Re: [PATCH RESEND 1/2] perf evlist: Return first evsel for non-sample event on old kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F45A2AF.8050003@lge.com>
Date:	Thu, 23 Feb 2012 11:21:35 +0900
From:	Namhyung Kim <namhyung.kim@....com>
To:	undisclosed-recipients:;
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/2] perf evlist: Return first evsel for non-sample
 event on old kernel

Ping. :)


2012-02-20 10:47 AM, Namhyung Kim wrote:
> On old kernels that don't support sample_id_all feature,
> perf_evlist__id2evsel() returns NULL for non-sampling events.
> This breaks perf top when multiple events are given on command
> line. Fix it by using first evsel in the evlist. This will also
> prevent getting the same (potential) problem in such new tool/
> old kernel combo.
>
> Suggested-by: Arnaldo Carvalho de Melo<acme@...stprotocols.net>
> Signed-off-by: Namhyung Kim<namhyung.kim@....com>
> ---
>   tools/perf/util/evlist.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 5c61dc57d7c7..f8da9fada002 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -349,6 +349,10 @@ struct perf_evsel *perf_evlist__id2evsel(struct perf_evlist *evlist, u64 id)
>   	hlist_for_each_entry(sid, pos, head, node)
>   		if (sid->id == id)
>   			return sid->evsel;
> +
> +	if (!perf_evlist__sample_id_all(evlist))
> +		return list_entry(evlist->entries.next, struct perf_evsel, node);
> +
>   	return NULL;
>   }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/