lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Feb 2012 12:44:26 -0800
From:	Jesse Barnes <>
To:	Yinghai Lu <>
Subject: Re: [PATCH -v2 1/4] PCI: Add class support in quirk handling

On Wed, 15 Feb 2012 21:40:29 -0800
Yinghai Lu <> wrote:

> Recently there is new support to make quirk calling will report duration time.
> That will boot log get more print out with initcall_debug is specified.
> Found a lot of quirks are calling for not related devices.
> Reason is quirk frame do not support class handling. So quirk code have to
> use PCI_ANY_ID for vendor/device and let quirk code itself to check class
> inside the func.
> The patch add class and cls_shift into struct pci_fixup.
> Also update related macro to accept the class and shift.
> -v2: fix v1 that left over of sparated patch.

I like this series, a few comments:
  - class and class_shift everywhere (in pci_fixup {} and the new
    macros) for readability
  - split the individual quirk fixes into separate patches (makes it
    easier to revert or identify if one breaks)
  - the reassigndev patch looks like a good one independent of the

Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists