linux-kernel - Re: [PATCH v3 11/21] ARM: at91/PMC: move assignment out of printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Feb 2012 08:50:44 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	plagnioj@...osoft.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux@....linux.org.uk, arnd@...db.de
Subject: Re: [PATCH v3 11/21] ARM: at91/PMC: move assignment out of printf

On 24/02/12 01:25, Nicolas Ferre wrote:

> We move the assignment of values of register out of the
> seq_printf() calls: It is obviously more readable.
> 
> Reported-by: Ryan Mallon <rmallon@...il.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>


Thanks:

Acked-by: Ryan Mallon <rmallon@...il.com>

> ---
>  arch/arm/mach-at91/clock.c |   15 ++++++++++-----
>  1 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/clock.c b/arch/arm/mach-at91/clock.c
> index d1b4e07..9ab8627 100644
> --- a/arch/arm/mach-at91/clock.c
> +++ b/arch/arm/mach-at91/clock.c
> @@ -432,19 +432,24 @@ static int at91_clk_show(struct seq_file *s, void *unused)
>  	u32		scsr, pcsr, uckr = 0, sr;
>  	struct clk	*clk;
>  
> -	seq_printf(s, "SCSR = %8x\n", scsr = at91_sys_read(AT91_PMC_SCSR));
> -	seq_printf(s, "PCSR = %8x\n", pcsr = at91_sys_read(AT91_PMC_PCSR));
> +	scsr = at91_sys_read(AT91_PMC_SCSR);
> +	pcsr = at91_sys_read(AT91_PMC_PCSR);
> +	sr = at91_sys_read(AT91_PMC_SR);
> +	seq_printf(s, "SCSR = %8x\n", scsr);
> +	seq_printf(s, "PCSR = %8x\n", pcsr);
>  	seq_printf(s, "MOR  = %8x\n", at91_sys_read(AT91_CKGR_MOR));
>  	seq_printf(s, "MCFR = %8x\n", at91_sys_read(AT91_CKGR_MCFR));
>  	seq_printf(s, "PLLA = %8x\n", at91_sys_read(AT91_CKGR_PLLAR));
>  	if (cpu_has_pllb())
>  		seq_printf(s, "PLLB = %8x\n", at91_sys_read(AT91_CKGR_PLLBR));
> -	if (cpu_has_utmi())
> -		seq_printf(s, "UCKR = %8x\n", uckr = at91_sys_read(AT91_CKGR_UCKR));
> +	if (cpu_has_utmi()) {
> +		uckr = at91_sys_read(AT91_CKGR_UCKR);
> +		seq_printf(s, "UCKR = %8x\n", uckr);
> +	}
>  	seq_printf(s, "MCKR = %8x\n", at91_sys_read(AT91_PMC_MCKR));
>  	if (cpu_has_upll())
>  		seq_printf(s, "USB  = %8x\n", at91_sys_read(AT91_PMC_USB));
> -	seq_printf(s, "SR   = %8x\n", sr = at91_sys_read(AT91_PMC_SR));
> +	seq_printf(s, "SR   = %8x\n", sr);
>  
>  	seq_printf(s, "\n");
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/