linux-kernel - Re: Commit 529febe breaks usb on Freescale P1022

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120224101432.GK17178@legolas.emea.dhcp.ti.com>
Date:	Fri, 24 Feb 2012 12:14:33 +0200
From:	Felipe Balbi <balbi@...com>
To:	"Eibach, Dirk" <Eibach@...ys.de>
Cc:	balbi@...com, Shengzhou.Liu@...escale.com,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, stern@...land.harvard.edu
Subject: Re: Commit 529febe breaks usb on Freescale P1022

Hi,

On Fri, Feb 24, 2012 at 11:11:46AM +0100, Eibach, Dirk wrote:
>  
> 
> > > This commit introduces a check for the USB PHY clock.
> > > Problem is that CTRL_PHY_CLK_VALID bit seems not to be 
> > present on all 
> > > Freescale ehci implementations, at least P1022 does not have it. So 
> > > this check always fails and the driver never gets loaded.
> > 
> > hmm, you would need a revision check on that function then.
> 
> Since I have no idea which Freescale platforms provide this bit and
> which platforms don't, I suggest withdrawing this commit and do some
> investigation on Freescales side to do this properly.

Could be, but I would like to hear from Shengzhou first. Not sure what
Greg thinks though :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)