linux-kernel - Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F477515.1040303@mvista.com>
Date:	Fri, 24 Feb 2012 15:31:33 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	meng zhang <meng.zhang@...iatek.com>
CC:	smurf@...rf.noris.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces

Hello.

On 24-02-2012 10:41, meng zhang wrote:

> from: Meng Zhang<meng.zhang@...iatek.com>

> 1. This patch is based on kernel 3.0.0

    You should base on the recent kernel instead.

> 2. To declare the product IDs in option.c

> Signed-off-by: Meng Zhang<meng.zhang@...iatek.com>
> ---------------------------------------------------------------------------------------

    This line is not needed here.

> --- option.c	2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig	2011-10-07 22:50:04.000000000 +0800

    The patch should be applicablke with -p1 switch, i.e. based on the linux 
source root.

[...]
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
>   	{ USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */
>   	{ USB_DEVICE(ONDA_VENDOR_ID, ONDA_MT825UP) }, /* ONDA MT825UP modem */
>   	{ USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /*
> Samsung GT-B3730 LTE USB modem.*/
> -	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x00, 0x00) },

    You're not adding the device IDs, you're removing them.

> -	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
> -	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
> -	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) },	/* MediaTek MT6276M modem&  app port */

    The patch is line wrapped.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/