linux-kernel - Re: [PATCH] regulator: Set delay to 0 if set_voltage_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120224145132.GO5450@opensource.wolfsonmicro.com>
Date:	Fri, 24 Feb 2012 14:51:33 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: Set delay to 0 if set_voltage_time_sel
 callback returns error

On Fri, Feb 24, 2012 at 03:17:46PM +0800, Axel Lin wrote:

>  			delay = rdev->desc->ops->set_voltage_time_sel(rdev,
>  						old_selector, selector);
> +			if (delay < 0)
> +				delay = 0;

We should complain if we get an error rather than silently ignore it,
possibly we'll end up returning prior to the ramp finishing which may
break things.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)