linux-kernel - Re: [PATCH 2/3] usb: enable pci MSI/MSIX in usb core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1202241050520.1168-100000@iolanthe.rowland.org>
Date:	Fri, 24 Feb 2012 10:59:39 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Felipe Balbi <balbi@...com>
cc:	"Alex,Shi" <alex.shi@...el.com>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<andiry.xu@....com>, <clemens@...isch.de>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] usb: enable pci MSI/MSIX in usb core

On Fri, 24 Feb 2012, Felipe Balbi wrote:

> > > > > +			retval = request_irq(hcd->msix_entries[i].vector,
> > > > > +					(irq_handler_t)hcd->driver->msix_irq,
> > > 
> > > do you really need this cast here ?
> > 
> > Yes, otherwise the complain like here:
> > drivers/usb/core/hcd-pci.c:330: warning: passing argument 2 of ‘request_irq’ from incompatible pointer type
> > include/linux/interrupt.h:134: note: expected ‘irq_handler_t’ but argument is of type ‘enum irqreturn_t (* const)(int,  struct usb_hcd *)’
> 
> Alan, Sarah, is the definition of the IRQ handler wrong on the hc_driver
> structure ?

No.  It is never passed to request_irq().

> Alex, I think you should fix your definition for the msix_irq handler.

The second parameter in the prototype is supposed to be void *, not 
struct usb_hcd *.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/