lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120224160505.GF7762@sgi.com>
Date:	Fri, 24 Feb 2012 10:05:05 -0600
From:	Ben Myers <bpm@....com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	santosh nayak <santoshprasadnayak@...il.com>
Cc:	elder@...nel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, xfs@....sgi.com,
	xfs-masters@....sgi.com
Subject: Re: [PATCH] xfs: Use memset to initialize structure member.

Santosh,

On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@...il.com>
> > 
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> > 
> 
> You could just do:
> 	struct xfs_bmalloca     bma = {};

This aggregate initializer seems cleaner than memset.  Do you
mind resending the patch with Dan's suggestion?                                 
                                                                                
Thanks for your contribution.  ;)    

-Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ