linux-kernel - Re: [PATCH 1/1] drm/i915: fix operator precedence when enabling RC6p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Feb 2012 09:33:47 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Eugeni Dodonov <eugeni.dodonov@...el.com>
Cc:	intel-gfx@...ts.freedesktop.org, just.for.lkml@...glemail.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Dave Airlie <airlied@...hat.com>
Subject: Re: [PATCH 1/1] drm/i915: fix operator precedence when enabling
 RC6p

On Thu, 23 Feb 2012 23:57:06 -0200
Eugeni Dodonov <eugeni.dodonov@...el.com> wrote:

> As noticed by Torsten Kaiser, the operator precedence can play tricks with
> us here.
> 
> CC: Dave Airlie <airlied@...hat.com>
> CC: Jesse Barnes <jbarnes@...tuousgeek.org>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@...el.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e654f32..4871ba0 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8194,7 +8194,7 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv)
>  
>  	if (intel_enable_rc6(dev_priv->dev))
>  		rc6_mask = GEN6_RC_CTL_RC6_ENABLE |
> -			(IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0;
> +			((IS_GEN7(dev_priv->dev)) ? GEN6_RC_CTL_RC6p_ENABLE : 0);
>  
>  	I915_WRITE(GEN6_RC_CONTROL,
>  		   rc6_mask |

ugg yeah, with the old code we'd never end up enabling rc6 at all.
Pushed.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)