linux-kernel - Re: [PATCH, resend] x86-64: improve insn scheduling in SAVE_ARGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F47F167.6070203@zytor.com>
Date:	Fri, 24 Feb 2012 12:21:59 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	mingo@...e.hu, tglx@...utronix.de, ak@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH, resend] x86-64: improve insn scheduling in SAVE_ARGS_IRQ

On 02/24/2012 03:55 AM, Jan Beulich wrote:
>  	leaq -RBP(%rsp),%rdi	/* arg1 for handler */
> -	testl $3, CS(%rdi)
> +	testl $3, CS-RBP(%rsi)
>  	je 1f

IIRC there is no imm8 version of testl; could this be a testb instead or
is that going to cause stalls on some platforms you think?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/