linux-kernel - Re: [PATCH v2] USB: Support for LPC32xx SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120225035128.GA4455@pengutronix.de>
Date:	Sat, 25 Feb 2012 04:51:28 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Roland Stigge <stigge@...com.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kevin.wells@....com, Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH v2] USB: Support for LPC32xx SoC

> I would recomment telling this from the device itself rather than from the
> platform.

Basically yes...

> Unfortunately, the way that ohci handles the abstraction between the
> various implementations is backwards, it would be much easier if the
> main driver was following that model to start with.

... exactly for that reason I didn't suggest it. Looking at other ohci-sources
(e.g. ohci-omap.c), machine_is_* seems to be the consistent use-case.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)