linux-kernel - Re: [PATCH 5/6] amd5536udc: fix type of ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F48FD62.7090304@mvista.com>
Date:	Sat, 25 Feb 2012 19:25:22 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Cyril Roelandt <tipecaml@...il.com>
CC:	balbi@...com, dahlmann.thomas@...or.de, gregkh@...uxfoundation.org,
	linux-geode@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] amd5536udc: fix type of ep_string.

Hello.

On 25-02-2012 5:15, Cyril Roelandt wrote:

> Use "static const char *" instead of "static const char *const".

    You're doing exactly oppposite.

> Signed-off-by: Cyril Roelandt<tipecaml@...il.com>
> ---
>   drivers/usb/gadget/amd5536udc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index 3d563d0..16079bd 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -140,7 +140,7 @@ static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect,
>
>   /* endpoint names used for print */
>   static const char ep0_string[] = "ep0in";
> -static const char *ep_string[] = {
> +static const char *const ep_string[] = {
>   	ep0_string,
>   	"ep1in-int", "ep2in-bulk", "ep3in-bulk", "ep4in-bulk", "ep5in-bulk",
>   	"ep6in-bulk", "ep7in-bulk", "ep8in-bulk", "ep9in-bulk", "ep10in-bulk",

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/