lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Feb 2012 17:46:39 -0800 From: "H. Peter Anvin" <hpa@...or.com> To: Linus Torvalds <torvalds@...ux-foundation.org> CC: Andreas Schwab <schwab@...ux-m68k.org>, Ian Kent <raven@...maw.net>, David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org, autofs@...r.kernel.org, Thomas Meyer <thomas@...3r.de>, Al Viro <viro@...iv.linux.org.uk> Subject: Re: [PATCH] autofs4: fix compilation without CONFIG_COMPAT On 02/25/2012 05:31 PM, Linus Torvalds wrote: > On Sat, Feb 25, 2012 at 2:10 PM, Andreas Schwab <schwab@...ux-m68k.org> wrote: >> The compat_daemon stuff is only needed on x86-64, and is_compat_task is >> only defined with CONFIG_COMPAT, so disable it for all other >> configurations. > > Ugh, I hate the proliferation of #ifdefs in code when they aren't > really necessary. > > How about this patch instead? It's small, simple, and clean. Maybe it > would even allow a few other #ifdef's to be removed (I see one in > kernel/seccomp.c, for example, although I suspect that > 'mode1_syscalls_32' might also be a compat-only thing, so who knows) > > And if you worry about the size of autofs_sb_info, I think that could > be made denser by using 'char' or bitfields instead of the various > ints that hold small values or flags instead. > I think this patch could help clean up other places, too. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists