lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 27 Feb 2012 09:45:48 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux@....linux.org.uk, arnd@...db.de
Subject: Re: [PATCH v3 17/21] ARM: at91: merge SRAM Memory banks thanks to
 mirroring

On 25/02/12 03:54, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 08:47 Fri 24 Feb     , Ryan Mallon wrote:
>> On 24/02/12 01:26, Nicolas Ferre wrote:
>>
>>> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
>>>
>>> On at91sam9260 and at91sam9g20 the SRAM banks are mirrored. We can
>>> merge them together to be able to have bigger and continuous
>>> internal RAM.
>>
>> I think this patch needs some comments in the code. As mentioned in the
>> last round, this functionality is not documented, so it is not obvious
>> how/why this works. This is especially true for any user who has
>> problems with this code and then tries to look up those addresses in
>> their at91 manual only to find the regions are reserved.
>>
>> Nicolas, are you able to give an official Atmel stance on this?
> you have the ack from Nico and he send the e-mail

Sure, but it would be nice to get some official documentation on this.
Why was the feature, which seems quite useful, never documented? Is it
supported on all revisions of the chips? Are there any restrictions or
caveats to using the mirrored layout versus the separate layout?

At the very least, the code needs to be documented, since anyone using
this code is not able to look up the details in the at91 technical manuals.

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists