linux-kernel - Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120225.212805.1394065389987976077.davem@davemloft.net>
Date:	Sat, 25 Feb 2012 21:28:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	baruch@...s.co.il
Cc:	stigge@...com.de, jeffrey.t.kirsher@...el.com,
	alexander.h.duyck@...el.com, eilong@...adcom.com,
	ian.campbell@...rix.com, netdev@...r.kernel.org,
	w.sang@...gutronix.de, linux-kernel@...r.kernel.org,
	kevin.wells@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

From: Baruch Siach <baruch@...s.co.il>
Date: Sun, 26 Feb 2012 03:52:18 +0200

> Hi Roland,
> 
> On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
>> This patch adds an ethernet driver for the LPC32xx ARM SoC.
>> 
>> Signed-off-by: Roland Stigge <stigge@...com.de>
> 
> [snip]
> 
>> +static int __init ethaddr(char *s)
>> +{
>> +	int i;
>> +	unsigned int r[6];
>> +
>> +	sscanf(s, "%x:%x:%x:%x:%x:%x",
>> +			&r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
>> +	for (i = 0; i < 6; i++)
>> +		mac_address[i] = (u8)r[i];
>> +
>> +	return 1;
>> +}
>> +__setup("ethaddr=", ethaddr);
> 
> Please use a module_param() instead of a top level kernel parameter.

Actually, remove this entirely, we don't add module parameters
to force the ethernet address.  That should be done in userland
in some fashion.

We've had many discussions about this recently, and this is the
consistent policy we want to enforce in all drivers from now on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/