lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Feb 2012 22:05:51 +0100 From: Sam Ravnborg <sam@...nborg.org> To: Bernhard Walle <bernhard@...lle.de> Cc: mmarek@...e.cz, lacombar@...il.com, linux-kernel@...r.kernel.org, linux-kbuild <linux-kbuild@...r.kernel.org>, zippel@...ux-m68k.org Subject: Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" On Sun, Feb 26, 2012 at 06:51:34PM +0100, Bernhard Walle wrote: > Am 26.02.12 18:48, schrieb Sam Ravnborg: > >> > --- a/scripts/Kbuild.include > >> > +++ b/scripts/Kbuild.include > >> > @@ -104,7 +104,7 @@ as-option = $(call try-run,\ > >> > # Usage: cflags-y += $(call as-instr,instr,option1,option2) > >> > > >> > as-instr = $(call try-run,\ > >> > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >> > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >> > > >> > # cc-option > >> > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) > > Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 > > > > I cannot remember why - but it would be good if you could dig up > > why - just so we do not hit an old issue again. > > Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" > since format strings inside $(1) would be interpreted. Makes good sense. > > But maybe Roman can comment on that? Cc'ing him. Would be good to hear from Roman - but he has been MIA for some years now :-( Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists